[eresi-dev] libasm Makefile problem

[zadig bru]

> This is incorrect. First libasm is linked entirely as a single .o
> (for inclusion in the libe2dbg), then libasm is linked as a shared
> library (for linking with the top-level executables).

mmm, it seems that the opposite is done. On line 143 there is:
        $(LD) -L../libaspect/ -laspect32 -shared ${OBJS32_libasm} -o libasm32.so

This builds the shared library, and then line 148 there is:
        $(LD) -r $(OBJS32_libasm) -o ${NAME32_libasm_o}
That builds the relocatable object. The remaining lines near "ifeq
($(IRIX),1)" seem redondant (and incomplete) with the first build
command to me.

> Also, the patch in the Makefile of libelfsh is incorrect : -L
> and -l are linking options while CFLAGS is a compiling variable.
> I have modified the makefile so that the missing stuffs you
> mention are put in LDFLAGS.

Yes you're right, thanks for applying the changes.

> All other patches have been integrated and commited in
> the current svn trunk. I compiled them in both 32 and 64
> bits. Consider testing this too on your BeOS (use --enable-32-64
> in the configure and make sure everything compiles until
> the end).

Thanks a lot. I will update my tree and recompile everything.

> You might also want to do a : source env.sh before compiling
> so that the testsuite is well compiled.

This will be the next step. These first patches just allow to compile
all elements (except e2dbg), and get an elfsh binary that starts. I
still have to merge the old patches I wrote to get code injection
working. Then I will play with the testsuite to see what is working or
not.